Replace MD5 hashes by SHA-512 - Githubissues

KBNLresearch / iromlab

Loader software for automated imaging of optical media with Nimbie disc robot

Apache License 2.0

33 stars 5 forks source link

Replace MD5 hashes by SHA-512 #53

Closed bitsgalore closed 7 years ago

bitsgalore commented 7 years ago

Why:

In METS file we're using SHA-512 anyway
Performance differences between MD5 and SHA-512 are really small.

Examples using this test script:

Output for 316 MB ISO

timeMD5: 0.6470000743865967 s
timeSha512: 0.8460001945495605 s
timeMD5: 0.6459999084472656 s
timeSha512: 0.8480000495910645 s
timeMD5: 0.6459999084472656 s
timeSha512: 0.8459999561309814 s
timeMD5: 0.6450002193450928 s
timeSha512: 0.8550000190734863 s
timeMD5: 0.6449999809265137 s
timeSha512: 0.8459999561309814 s
timeMD5: 0.6469998359680176 s
timeSha512: 0.8430001735687256 s

Output for 2 GB ISO

timeMD5: 64.60599970817566 s
timeSha512: 5.9009997844696045 s
timeMD5: 4.439000129699707 s
timeSha512: 5.829999923706055 s
timeMD5: 4.446000099182129 s
timeSha512: 5.822999954223633 s
timeMD5: 4.440000057220459 s
timeSha512: 5.816999912261963 s
timeMD5: 4.444999933242798 s
timeSha512: 5.817000150680542 s
timeMD5: 4.44700026512146 s
timeSha512: 5.817999839782715 s

So differences are minimal, and for large files they are negligible relative to I/O process.

bitsgalore commented 7 years ago

Done: https://github.com/KBNLresearch/iromlab/commit/ddf6f23ff5a46490e2826eb215d89373d30effe6