KBNLresearch / iromlab

Loader software for automated imaging of optical media with Nimbie disc robot
Apache License 2.0
31 stars 5 forks source link

Post-install skipped after changes to pyinstaller script #58

Closed bitsgalore closed 6 years ago

bitsgalore commented 7 years ago

This probably related to the fact that iromlab now uses wheels, see:

https://github.com/pypa/packaging-problems/issues/64

Suggestion here:

https://stackoverflow.com/questions/24263774/post-install-script-after-installing-a-wheel#comment41929643_24749871

First step would then be to create a separate config script and include that in the package.

bitsgalore commented 7 years ago

First step: moved post-installation code to a separate script that needs to be executed by the user after installation. While at it also got rid of copying the executables of the wrapped tools to the Window User dir, as they can be accessed without problems from within the package:

https://github.com/KBNLresearch/iromlab/commit/911470b82b8690d7f9294e0844ae94b388fa2786

Not ideal b/c user needs to dig down into the Python/Scripts directory to find the configuration exe, but at least it works ...

TODO:

bitsgalore commented 6 years ago

All done!