KBNLresearch / omSipCreator

Create ingest-ready SIPs from batches of optical media images
Apache License 2.0
7 stars 0 forks source link

Refactor ideas #1

Closed bitsgalore closed 6 years ago

bitsgalore commented 8 years ago

Code is getting a bit of a mess as it is now. Refactor ideas: create separate classes for batch and carriers and wrap elements inside them.

bitsgalore commented 6 years ago

Refactor ideas/notes:

omSipCreator.py

1283 lines

main

433 lines

processPPN

args:

returns: -

287 lines

processCarrier

args:

returns:

332 lines

get_immediate_subdirectories

called from main

checkFileExists

called from main

readChecksums

called from processCarrier

generate_file_sha512

called from processCarrier, main

errorExit function in main, but alled from other modules --> move to shared module!

bitsgalore commented 6 years ago

Done https://github.com/KBNLresearch/omSipCreator/releases/tag/0.5.0