KBNLresearch / omSipCreator

Create ingest-ready SIPs from batches of optical media images
Apache License 2.0
7 stars 0 forks source link

Query for Title sometimes doesn't return main title #37

Closed bitsgalore closed 7 years ago

bitsgalore commented 7 years ago

Copied from https://github.com/KBNLresearch/iromlab/issues/51, affects OmSipCreator as well.

Examples:

http://jsru.kb.nl/sru/sru?x-collection=GGC&operation=searchRetrieve&startRecord=1&maximumRecords=1&recordSchema=dcx&query=26732653X

Here Iromlab returns:

<dc:title xml:lang="nl" xsi:type="dcx:intermediatetitle">3 vwo</dc:title>

But instead it should return this:

<dc:title xml:lang="nl" xsi:type="dcx:maintitle">D'accord!. Frans voor de onderbouw. Docentenaudio</dc:title>

Other example:

http://jsru.kb.nl/sru/sru?x-collection=GGC&operation=searchRetrieve&startRecord=1&maximumRecords=1&recordSchema=dcx&query=185299814

Iromlab returns:

<dc:title xml:lang="nl" xsi:type="dcx:intermediatetitle">2 vbo mavo</dc:title>

But should return this instead:

<dc:title xml:lang="nl" xsi:type="dcx:maintitle">Stemming : muziek voor de basisvorming. CD's</dc:title>

So search for Title may need additional check to ensure xsi:type=dcx:maintitle.

This will go wrong in omSipCreator as well.

bitsgalore commented 7 years ago

Fixed: https://github.com/KBNLresearch/omSipCreator/commit/65d4f267350b543a753ce980f2502fdd7148e1e5