search

KBNLresearch / omSipCreator

Create ingest-ready SIPs from batches of optical media images
Apache License 2.0
7 stars 0 forks source link

Fix duplicate techMD ID values #57

Closed bitsgalore closed 6 years ago

bitsgalore commented 6 years ago

After commit https://github.com/KBNLresearch/omSipCreator/commit/4353fb7621f3f0bbd0bb6805c9aef2a58b4f7b53 numbering of techMD goes wrong (duplicate values)

bitsgalore commented 6 years ago

Culprit most likely this:

https://github.com/KBNLresearch/omSipCreator/blob/refactor/omSipCreator/ppn.py#L187

techID = "techMD_" + str(counterTechMD)

which should be:

techID = "techMD_" + str(thisCarrier.counterTechMD)
bitsgalore commented 6 years ago

Fixed (along with some other numbering issues) by https://github.com/KBNLresearch/omSipCreator/commit/af73aaa27c736520524f3ffa251b78df1e5a8077 and https://github.com/KBNLresearch/omSipCreator/commit/4c48c4b5f4eab1429bcd123e04e63183bd46b444