KBheid / PixelmonDatapackCreator

Create datapacks for Pixelmon mod with a graphical interface
MIT License
2 stars 0 forks source link

Cull unnecessary data on export data #6

Open KBheid opened 1 year ago

KBheid commented 1 year ago

If something doesn't have values, do not add it.

KBheid commented 1 year ago

I believe this could do it. We could switch on, for example, evolution condition type and only serialize the respective data for that.

KBheid commented 1 year ago

Currently, we have issue with Evolution Conditions - primarily the shiny condition.

It is also worth considering the following points:

An important point to note here is that any form that isn't default will inherit fields at the forms top level from the default if they aren't specified (i.e: You can inherit the entire moves object, but not just the levelUpMoves because that's a level nested inside moves). A good example of this in practice is battle bond greninja (note this is a seprate form to ash greninja which gets better stats etc) - which only changes abilities, egg groups and male percentage and inherits the rest from default greninja

KBheid commented 1 year ago

Lastly, there is also some issue with marking things with [IgnoreZero] - such as malePercentage, considering some Pokemon such as Nidoqueen and its pre-evolutions mark it as 0 and include it.