search

KBlixt / subcleaner

removes ads from subtitle files cleanly.
284 stars 12 forks source link

Added -m (minimal) and -e (errors only) flags #18

Closed ChristianMalazarte closed 1 year ago

ChristianMalazarte commented 1 year ago

Plus more regex strings.

KBlixt commented 1 year ago

Hi, I've been unavailable for a while. I've been looking at the code and I need some clarifications:

what's the different between --errors only and --silent?

in the cleaner you are catching an indexError and printing out that decoding the file didn't work. I've refactored the code and will be handling this in a future in a better way. I removed it since it will be added in the future anyway and was in conflict with a fix I had to do earlier.

I'll keep in mind the options you've added here but I might overhaul the verbosity of the script entirely.