KC3Kai / kancolle-replay

Sortie Replay and Simulation by @fourinone41
MIT License
52 stars 34 forks source link

Shoot order in Night battle #66

Closed BlackJack255 closed 2 years ago

BlackJack255 commented 2 years ago

Shooting order in night battle should be different from day battle second round. In night battle, the sunk ship should be skipped, and no succeeding active/alive ships taking over its position even if the ship sunk before night battle(sunk in day battle).

Succeeding active/alive ships taking over the position of sunk ship in end of day battle first round, but not in night battle

Here's an example when night battle start, sunk ships happened in day time

our enemy 1 okay 1 okay 2 okay 2 okay 3 okay 3 sunk 4 okay 4 sunk 5 okay 5 sunk 6 okay 6 okay

Expetced shooting order like: our 1 -> enemy 1 -> our 2 -> enemy 2 -> our 3 -> enemy 3(skip) -> our 4 -> enemy 4(skip) -> our 5 -> enemy 5(skip) -> our 6 -> enemy 6

But I see from Replayer is: our 1 -> enemy 1 -> our 2 -> enemy 2 -> our 3 -> enemy 6 (smallest succeeding to 3rd) -> our 4 -> skip -> our 5 -> skip -> our 6 ->

This is the rule for day battle second round, but not for night battle, seems some logic error here, maybe miss-using the day battle rule into night battle?

BlackJack255 commented 2 years ago

I found that the issue happened in friend fleet stage, succeeding active/alive ships does take over sunk ship, different from night battle, so there's no bug