search

KCSU / website-theme

the KCSU website theme
3 stars 0 forks source link

All the avatars are the same in /exec #20

Closed gfarrell closed 11 years ago

gfarrell commented 11 years ago

The avatars should all be different, but it would seem that they are all the same.

Check out what get_wp_user_avatar() is doing (since it's a plugin).

Burgch commented 11 years ago

OK, I think I understand the plugin. It would do this if the ID being passed wasn't numeric (?) or if it didn't return a valid user, in which case it just defaults to the current user. However, I see you when I visit the exec page, which leads me to believe it is somehow being passed zero or something for the user ID. The changes I made in 69e6607 might help but I don't know...

gfarrell commented 11 years ago

Yeah it is, because none of those users exist yet (so it is fetching blank users). The reason I am using it is that if I use get_avatar (vanilla WP) I just get a generic image, not my avatar, so I gave up trying to make get_avatar work… I suppose we could just stop it fetching users if the user is blank (i.e. not add it to the array) and just add an "empty" profile pic and name (empty!).

On Thursday, 18 April 2013 at 11:34, Conor Burgess wrote:

OK, I think I understand the plugin. It would do this if the ID being passed wasn't numeric (?) or if it didn't return a valid user, in which case it just defaults to the current user. However, I see you when I visit the exec page, which leads me to believe it is somehow being passed zero or something for the user ID. The changes I made in 69e6607 (https://github.com/KCSU/website-theme/commit/69e6607) might help but I don't know...

— Reply to this email directly or view it on GitHub (https://github.com/KCSU/website-theme/issues/20#issuecomment-16569139).

gfarrell commented 11 years ago

Still seem to be getting this

screen shot 2013-09-09 at 01 59 52

Burgch commented 11 years ago

Have you read the commit message? It's because the users don't exist. As soon as they do, it works just fine :)

On 9 Sep 2013, at 01:00, Gideon Farrell wrote:

Still seem to be getting this [Uploading Screen Shot 2013-09-09 at 01.59.52.png . . .]()

— Reply to this email directly or view it on GitHub.

gfarrell commented 11 years ago

Ah right. Guilty as charged.

It still is weird that it does that...

Burgch commented 11 years ago

I know; I couldn't really understand why it chooses you, but there's some weird stuff about if the ID is non-numeric (like NULL), it uses the comment author or something weird. I don't like reading their code so didn't dig deeper. It should work as we want it to so I wasn't too bothered!

On 9 Sep 2013, at 10:29, Gideon Farrell wrote:

Ah right. Guilty as charged.

It still is weird that it does that...

— Reply to this email directly or view it on GitHub.

Burgch commented 11 years ago

Fixed properly with a generic Exec Member user who is assigned if the incumbent doesn't have a user account.