search

KCSU / website-theme

the KCSU website theme
3 stars 0 forks source link

exec page should use first+last name not nickname #22

Closed gfarrell closed 11 years ago

gfarrell commented 11 years ago

Nickname is, by default, the CRSID. If we just use first+last name it'll be more robust.

Burgch commented 11 years ago

No, it uses display_name, but Nekane had that set to her login (with the display name publicly as field in the user settings), so once that is correctly set it works fine :)

On 9 Sep 2013, at 22:17, Gideon Farrell wrote:

Nickname is, by default, the CRSID. If we just use first+last name it'll be more robust.

— Reply to this email directly or view it on GitHub.

Burgch commented 11 years ago

Oh you mean manually use first name last name so it'll work even if the user doesn't set display name properly! I see, that makes more sense. Shall do so asap :)

On 9 Sep 2013, at 22:17, Gideon Farrell wrote:

Nickname is, by default, the CRSID. If we just use first+last name it'll be more robust.

— Reply to this email directly or view it on GitHub.

gfarrell commented 11 years ago

Yeah I know we can get it right by changing the display name on a user, but i wonder if it wouldn't be better to use first+last.

On Tuesday, 10 September 2013 at 08:20, Conor Burgess wrote:

No, it uses display_name, but Nekane had that set to her login (with the display name publicly as field in the user settings), so once that is correctly set it works fine :)

On 9 Sep 2013, at 22:17, Gideon Farrell wrote:

Nickname is, by default, the CRSID. If we just use first+last name it'll be more robust.

—
Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub (https://github.com/KCSU/website-theme/issues/22#issuecomment-24136533).

gfarrell commented 11 years ago

Exactly.

On Tuesday, 10 September 2013 at 08:22, Conor Burgess wrote:

Oh you mean manually use first name last name so it'll work even if the user doesn't set display name properly! I see, that makes more sense. Shall do so asap :)

On 9 Sep 2013, at 22:17, Gideon Farrell wrote:

Nickname is, by default, the CRSID. If we just use first+last name it'll be more robust.

—
Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub (https://github.com/KCSU/website-theme/issues/22#issuecomment-24136566).

Burgch commented 11 years ago

Done :)