Some (mainly quests) changes

KCV-Localisation / KanColleViewer-Translations

Translation files for KCV

BSD 2-Clause "Simplified" License

8 stars 13 forks source link

Some (mainly quests) changes #31

Closed gakada closed 9 years ago

gakada commented 9 years ago

Also

There are some changes going on with equipment translations on Wikia (1, 2), what do you think about following them?
AFAIK not everything is translated in Operations.xml, but I think that having a module that can map from API to node labels (from wiki, A, B, C, etc., like in 5-4-A) would be better, so that these labels can be used in Logger, Overview (i.e. to show the current node when in sortie), etc., maybe leaving translations as an optional addition.

Yuubari commented 9 years ago

Can you provide a rationale for “FBB”?

gakada commented 9 years ago

1) Isn't it a common term in the game community? (not historically of course, but in the game BB and BBV are "slow", while Fast BB are, well, "fast"), 2) all ship types are codes in ShipTypes.xml, except "Fast BB" that uses the word "fast", 3) I want to explicitly specify classes in quest descriptions, so FBB/BB for "battleship, BBV don't count" or BB/BBV for "slow battleship" (no FBB here). So not really an important thing, just used it as a somewhat shorter variant for "Fast BB" that is also known.

Yuubari commented 9 years ago

I'd rather leave it as is.

Also, removing exclamation marks in quest titles was a conscious decision, not an omission/error. Why do you want to re-introduce them?

gakada commented 9 years ago

Quite a few titles still have them here, do you want me to remove all exclamation marks?

Yuubari commented 9 years ago

That would be pretty nice. I wanted to get around to it but I constantly get distracted by other things (like re-implementing translations in 4.x right now, for example).

gakada commented 9 years ago

As an off-topic (but related to translations), TranslationsPath, but there is also mainFolder, so I guess it's possible to make a public static readonly string field in KanColleClient using Path.GetDirectoryName(Assembly.GetEntryAssembly().Location) and use it everywhere (Logger, Translations), this should resolve those problems (it worked for me).

Yuubari commented 9 years ago

That's already done in the newest code revision. The translations branch is very, very work in progress and I'm iterating through different approaches every day.

Currently it's

var workingDirectory = Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location) ?? "";
translationsPath = Path.Combine(workingDirectory, "Translations");

(Note that you can comment on commits on GitHub.)

Yuubari commented 9 years ago

Merged this just now; I've restored exclamation marks in the quest titles that are direct speech and corrected some titles to read/sound better.