Closed gakada closed 9 years ago
Can you provide a rationale for “FBB”?
1) Isn't it a common term in the game community? (not historically of course, but in the game BB and BBV are "slow", while Fast BB are, well, "fast"), 2) all ship types are codes in ShipTypes.xml, except "Fast BB" that uses the word "fast", 3) I want to explicitly specify classes in quest descriptions, so FBB/BB for "battleship, BBV don't count" or BB/BBV for "slow battleship" (no FBB here). So not really an important thing, just used it as a somewhat shorter variant for "Fast BB" that is also known.
I'd rather leave it as is.
Also, removing exclamation marks in quest titles was a conscious decision, not an omission/error. Why do you want to re-introduce them?
Quite a few titles still have them here, do you want me to remove all exclamation marks?
That would be pretty nice. I wanted to get around to it but I constantly get distracted by other things (like re-implementing translations in 4.x right now, for example).
As an off-topic (but related to translations), TranslationsPath, but there is also mainFolder, so I guess it's possible to make a public static readonly string
field in KanColleClient using Path.GetDirectoryName(Assembly.GetEntryAssembly().Location)
and use it everywhere (Logger, Translations), this should resolve those problems (it worked for me).
That's already done in the newest code revision. The translations branch is very, very work in progress and I'm iterating through different approaches every day.
Currently it's
var workingDirectory = Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location) ?? "";
translationsPath = Path.Combine(workingDirectory, "Translations");
(Note that you can comment on commits on GitHub.)
Merged this just now; I've restored exclamation marks in the quest titles that are direct speech and corrected some titles to read/sound better.
Also