KCarlile / guitar-diagrams-js

Open source JavaScript library for drawing guitar chords and scales on an HTML5 canvas.
https://demo.kcarlile.com/guitar-diagrams-js/
GNU General Public License v3.0
0 stars 0 forks source link

Last fret is cutoff with string names #16

Closed KCarlile closed 2 months ago

KCarlile commented 2 months ago

Background

It seems that the last fret is getting cutoff when string names are enabled. On the examples page, the blank fretboard (example 1) renders correctly, but any other diagrams with string names enabled appears to have the last fret cutoff.

Acceptance Criteria

Approach

Notes

TBD

KCarlile commented 2 months ago

Created static stringNamePaddingFactor = 1.5; static global value that is used for padding the string name height. This needed to be added in multiple places, so the factor is defined once.

KCarlile commented 2 months ago

PR: #21