Not all options are configurable - Githubissues

KCarlile / guitar-diagrams-js

Open source JavaScript library for drawing guitar chords and scales on an HTML5 canvas.

https://demo.kcarlile.com/guitar-diagrams-js/

GNU General Public License v3.0

0 stars 0 forks source link

Not all options are configurable #6

Closed KCarlile closed 3 months ago

KCarlile commented 3 months ago

Background

Some configuration options remain hard-coded, but they should all be configurable by the user.

Acceptance Criteria

All options that should configurable are identified and made configurable via this.#config.* ❌

Approach

TBD

Notes

TBD

KCarlile commented 3 months ago

The following items need to be addressed:

~~String marker font @ 170, 199~~ Decided to not do this as changing font may require changing font size as well, but those are relative to all other base numbers, so even the base font size might need to be changed.
Marker stroke width @ 416, 436 ✅
Marker font size @ 430 ✅
~~Marker font @ 458~~ See above for explanation.
~~Marker triangle radius factor @ 507~~ Ditching this for now.
~~Marker diamond radius factor @ 529~~ Ditching this for now.