KD4Z / md380tools-vm

Enhanced Toolkit for md380tools- MD-380 / MD-390 / Retevis RT3 or RT8 radios. Windows VM or Linux
97 stars 28 forks source link

Bug found in building the users database #13

Closed jdrago closed 7 years ago

jdrago commented 7 years ago

Hi Warren,

The 'user.bin' file is getting munged-up anytime a static.users file is included.

I first noticed the issue when I created one entry in the static.users file using this format (101,call1,name1,city1,state1,nickname1,country1) . The actual entry is: 3139370,W8FAA,John,Atwater,OH,John,USA When the database is created, I do a lookup on the callsign with ./lookup W8FAA. Lookup returns two results. The first is my record as shown above. The second is (at the time of this post) a record for call CX1RK. This second record is the record for CX1RK from the database, but it has my record concatenated to the end of it.

SO, I removed my record from static.users and re-ran 'glvusers'. The user.bin file is still corrupt in the same place, but with different data. Something is wrong in the process that merges the data together.

Edit: Looks like CX1RK is the last entry in the original user.bin file. The issue is the addstatic script may not be adding a LF before inserting the static.users file.

73, John W8FAA john.drago@mac.com

PD0DIB commented 7 years ago

Hi John, Is it possible the "old" entry is from before mid December 2016?

That's the period Warren did a store of the MARC database before MARC decided to filter the database extraction; I.e. did not included name and address info anymore.

That stored 'froozen' file with the full dataset is always added when you execute a glv or glvusers to make the database as complete as possible (as in the 'old' days). So it is not a bug, it is a non documented feature. 73 de PD0DIB

Op 26 mrt. 2017 9:45 p.m. schreef "John Drago" notifications@github.com:

Hi Warren,

The 'user.bin' file is getting munged-up after running 'glvusers'. I first noticed the issue when I created one entry in the static.users file using this format (101,call1,name1,city1,state1,nickname1,country1) . The actual entry is: 3139370,W8FAA,John,Atwater,OH,John,USA When the database is created, I do a lookup on the callsign with ./lookup W8FAA. Lookup returns two results. The first is my record as shown above. The second is (at the time of this post) a record for call CX1RK. This second record is the record for CX1RK from the database, but it has my record concatenated to the end of it.

SO, I removed my record from static.users and re-ran 'glvusers'. The user.bin file is still corrupt in the same place, but with different data. Something is wrong in the process that merges the data together.

I'm still walking through the scripts to see if I can identify the issue, Please feel free to contact me.

73, John W8FAA john.drago@mac.com

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/KD4Z/md380tools-vm/issues/13, or mute the thread https://github.com/notifications/unsubscribe-auth/AXfxP3lwPl7s5bY6zJ9Y3w_G7BBQ9fm5ks5rpquCgaJpZM4Mphdy .

KD4Z commented 7 years ago

John, glv now and see if you have the same issue. After glv, you can go back to glvusers again. The seed file, the static.users file, and the dmr-marc.tmp file get appended together and there needed to be a line break added after the seed file. CX1RX happens to be the last entry in the seed file.

jdrago commented 7 years ago

Yes, the issue looks like it is corrected. However, FYI, there is a blank entry (,,,,,,) in line 2 of the user.bin file after the ‘glv’. Thank you,

73, John

On Mar 26, 2017, at 10:15 PM, KD4Z notifications@github.com wrote:

John, glv now and see if you have the same issue. After glv, you can go back to glvusers again. The seed file, the static.users file, and the dmr-marc.tmp file get appended together and there needed to be a line break added after the seed file. CX1RX happens to be the last entry in the seed file.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KD4Z/md380tools-vm/issues/13#issuecomment-289337976, or mute the thread https://github.com/notifications/unsubscribe-auth/AACaxuxpfGyTg4jbsPDLuCd5o1nJvX0Wks5rpxuugaJpZM4Mphdy.

KD4Z commented 7 years ago

blank line removed.