search

KDAB / KDDockWidgets

KDAB's Dock Widget Framework for Qt
https://www.kdab.com/development-resources/qt-tools/kddockwidgets
Other
754 stars 163 forks source link

GitHub actions add Python bindings to macos and windows #421

Closed dantti closed 10 months ago

dantti commented 10 months ago

@iamsergio so this one is finally done, Python3_FIND_VIRTUALENV is in cmake 3.15, so I upped but since it's just a var for CI we can revert it.

The midnight schedule has a few limitations, by default it runs on GitHub repository default branch, right now 2.0, we can tell the checkout sources script to use another branch but then it needs to be merged there, so it's a bit of chicken-egg problem.

After we merge this I will remove it from running on push/pull, otherwise we'd need to wait for it, and it wouldn't run as 2.0 can not be build with this yet...

The result seems simple but it was quite annoying to find out why my mac/win could build but this didn't find the right python...

iamsergio commented 10 months ago

please do atomic PRs, the clazy changes can't go in a commit message saying "[GitHub actions add Python bindings to macos and windows"

+1 for bumping the cmake version, just state the reason in the commit message

dantti commented 10 months ago

done