KDAB / KDDockWidgets

KDAB's Dock Widget Framework for Qt
https://www.kdab.com/development-resources/qt-tools/kddockwidgets
Other
754 stars 163 forks source link

nlohmann: fix use of unsupported CMake variable #433

Closed olafmandel closed 9 months ago

olafmandel commented 9 months ago

For CMake versions >=3.15, <3.17 the CMAKE_CURRENT_FUNCTION_LIST_DIR variable is not yet available, so searching for the local nlohmann header failes. Fix this by adding a workaround variable KKDockWidgets_PROJECT_ROOT that allows finding the correct directory anyway.

iamsergio commented 9 months ago

Hi, thank you for the contribution. Have you signed the CLA ? See https://kdab.github.io/KDDockWidgets/involved.html thanks

CLAassistant commented 9 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

olafmandel commented 9 months ago

Have you signed the CLA ? See https://kdab.github.io/KDDockWidgets/involved.html thanks

Already signed and sent in, see my eMail on 2023-01-16 to info@kdab.com

iamsergio commented 9 months ago

found it! thank you