KDAB / KDDockWidgets

KDAB's Dock Widget Framework for Qt
https://www.kdab.com/development-resources/qt-tools/kddockwidgets
Other
762 stars 164 forks source link

Overwrite PATH in CMakeUserPresets-example.json #469

Closed MiKom closed 7 months ago

MiKom commented 7 months ago

Without overwriting the PATH here, we will prepend "/bin:" to the PATH variable because in both dev6 and dev-asan6 we've got the following:

"environment": {
    "PATH": "$env{QT6_DIR}/bin:$penv{PATH}"
},

Which in the absence of QT6_DIR will prepend a bogus entry to PATH. It's not much of a problem on Linux because "/bin" is in the path anyway. But on Windows, it messes up the PATH completely. Windows uses ";" as PATH separator.

With this change, we overwrite the PATH in the user preset example making sure that it's not messed up. After all, the idea of these examples is that we rely on CMAKE_PREFIX_PATH to locate Qt and not on QT6_DIR.

I would even argue that we shouldn't modify PATH in dev6 and dev-asan6 as well since they set CMAKE_PREFIX_PATH which should be sufficient to do the compilation.

iamsergio commented 7 months ago

I've removed PATH as discussed, if CI is happy let's keep it that way

iamsergio commented 7 months ago

reopen is still required