search

KDAB / KDReports

Qt library for generating printable and exportable reports from code and from XML descriptions.
https://www.kdab.com/kd-reports/
Other
130 stars 44 forks source link

KDReports::Frame need setMargin functions #25

Open CMLDMR opened 3 years ago

CMLDMR commented 3 years ago

QTextFrameFormat class support setMargin functions; Top, Bottom, Right, Left or entire margins.

I implemented new functions to Frame class, 

    KDReports::Frame& setTopMargin( qreal topMargin );

    KDReports::Frame& setBottomMargin( qreal bottomMargin );

    KDReports::Frame& setLeftMargin( qreal leftMargin );

    KDReports::Frame& setRightMargin( qreal rightMargin );

    qreal topMargin() const;
    qreal bottomMargin() const;
    qreal leftMargin() const;
    qreal rightMargin() const;

now we can place to element to anywhere at the page.

image

dfaure-kdab commented 3 years ago

Cool. Can you make a merge request?

winterz commented 3 years ago

@CMLDMR thanks for helping with KDReports

Keep in mind that we (KDAB) could not accept a patch for this feature without your signature on the Copyright agreement as mentioned in our README. Of course @dfaure-kdab would need to accept the patch first.

Instructions and more info can be found in doc/KDReports-CopyrightAssignmentForm.pdf

CMLDMR commented 3 years ago

I implemented this and its very usefull and now I am using patched version. I wrote here for benefits to other users. I dont know very well github (like, pull request ) and what about Copyrights aggreement?

Thanks for Reply.

dfaure-kdab commented 3 years ago

@CMLDMR Do you still need help with making a pull request, if you're still interested in doing that?

CMLDMR commented 3 years ago

I created long time ago if it is in right way.

dfaure-kdab commented 3 years ago

Oh, right, sorry, that's https://github.com/KDAB/KDReports/pull/26 Let's discuss it there.