Open VelorumS opened 6 months ago
ahayzen-kdab
commented
6 months ago Interesting I can reproduce this as well. Wonder how this is supposed to work as we need the build script for the crate to work.
Does it work if you move the tests into another crate and then depend on qml-minimal-no-cmake as a crate? As i've seen that suggested as a solution in some places :thinking:
klochowicz
commented
3 months ago I've run it as well; in my setup, I don't have any integration tests depending on the bridge crate, but I happen to have both a cxx and cxx_qt bridge crates that I export as a single static library (to be able to link against it in my CMake project).
I sort of got around my issue by hiding cxx_qt bridge crate behind a feature flag, but it would be nice if there was a better option :)
LeonMatthesKDAB
commented
3 months ago I can reproduce this as well. The issue is that the build.rs script compiles our generated C++ code and links it. This is the correct behavior to build the binary.
Our main.rs file uses mod cxxqt_object; to ensure the bridge is built on the Rust side as well, which generates the functions you are missing.
As the integration test only builds the public interface, cargo test doesn't include the mod cxxqt_object;, as that's only in main.rs.
You can fix this by adding a lib.rs file:
mod cxxqt_object;Which should fix cargo test.
However, I've noticed that this somehow causes issues with qrc...
When I then cargo run, I get:
Finished dev [unoptimized + debuginfo] target(s) in 0.03s
Running `/home/kdab/Documents/projects/3371-Rust-RnD/cxx-qt/target/debug/qml-minimal-no-cmake`
QQmlApplicationEngine failed to load component
qrc:/qt/qml/com/kdab/cxx_qt/demo/qml/main.qml: No such file or directoryAnd the app doesn't load the window...
That issue disappears when I remove the lib.rs file again.
kristof-mattei
commented
3 months ago I can reproduce this as well. The issue is that the build.rs script compiles our generated C++ code and links it. This is the correct behavior to build the binary. Our
main.rsfile usesmod cxxqt_object;to ensure the bridge is built on the Rust side as well, which generates the functions you are missing.As the integration test only builds the public interface,
cargo testdoesn't include themod cxxqt_object;, as that's only inmain.rs. You can fix this by adding alib.rsfile:mod cxxqt_object;Which should fix
cargo test.However, I've noticed that this somehow causes issues with qrc... When I then
cargo run, I get:Finished dev [unoptimized + debuginfo] target(s) in 0.03s Running `/home/kdab/Documents/projects/3371-Rust-RnD/cxx-qt/target/debug/qml-minimal-no-cmake` QQmlApplicationEngine failed to load component qrc:/qt/qml/com/kdab/cxx_qt/demo/qml/main.qml: No such file or directoryAnd the app doesn't load the window...
That issue disappears when I remove the lib.rs file again.
I wonder if this has something to do with a missing Q_INIT_RESOURCE(). If we run the code with lib.rs it seems that from the Rust side the main function links against the lib. It's not that it is actually a recompilation of the whole code.
kristof-mattei
commented
3 months ago I created a repo with a repro: https://github.com/kristof-mattei/cxx-qt-lib-test
As-is (with src/lib.rs) it gives the following error:
= note: init.cpp:5: error: undefined reference to 'qInitResources_qml_module_resources_qrc()'
collect2: error: ld returned 1 exit statuswhich I traced to cxx-qt-generated. I tried to link it in build.rs but that doesn't help.
If you comment out shared::init_resources(); in src/main.rs:9 the error changes to:
QQmlApplicationEngine failed to load component
qrc:/qt/qml/cxx_qt_lib_test/qml/main.qml: No such file or directoryNow, if you remove src/lib.rs it works, with our without the init_resources() call.
kristof-mattei
commented
3 months ago https://github.com/kristof-mattei/cxx-qt-lib-test
The build.rs generates a single function that imports all plugins defined. Works on cargo run and cargo test
LeonMatthesKDAB
commented
2 months ago @kristof-mattei Thank you for investigating this further and providing a workaround.
@ahayzen-kdab We should try to integrate this into our build system, so that this happens automatically. I have the suspicion something like this already happens in our build system for the main binary, but potentially not in the integration tests :thinking:
kristof-mattei
commented
2 months ago @LeonMatthesKDAB the Q_IMPORT_PLUGIN string occurs in your code base. That's where I got the inspiration from, as Q_INIT_RESOURCES generates the same lines.
But there is a difference between runtime not finding the qml, which can be fixed with the import plugin hack I wrote, or the build error you get under certain conditions.
I think certain code gets thrown away in the latter condition because we're not calling it. Which is why we need that call in the tests just to make sure the linker understands the components are needed.
But that feels like a weird workaround. It's not Rust-like to have to do that. But I'm unsure how to tell the linker to retain stuff.
ahayzen-kdab
commented
2 months ago Note that unused things being thrown away by the compiler we've hit before and was solved by putting those parts of the code into their own lib which are linked with WHOLE_ARCHIVE or +whole-archive.
It's more of a Cargo problem...
If you want to add Rust integration tests (a
tests/dir alongside thesrc/):then there is a linker error when running
cargo test:Test itself (
integrationtest.rs):The goal of the integration tests is to launch the
qml-minimal-no-cmakebinary, simulate inputs, examine outputs. No cxx-qt dependency needed.So the test build is somehow incompatible with the
build.rs.Is there a way to make it just work by default without putting the tests in a separate crate?