search

KDAB / cxx-qt

Safe interop between Rust and Qt
https://kdab.github.io/cxx-qt/book/
993 stars 66 forks source link

cxx-qt-gen: move headers to cxx-qt crate #843

Closed ahayzen-kdab closed 5 months ago

ahayzen-kdab commented 6 months ago

Closes #844

ahayzen-kdab commented 6 months ago

Windows CI broke on this branch this time with the missing DLL, hoping it was related to add cxx-qt as a dependency to qt_types_standalone ...

ahayzen-kdab commented 6 months ago

Windows CI broke on this branch this time with the missing DLL, hoping it was related to add cxx-qt as a dependency to qt_types_standalone ...

Nope still fails, on my CI instance https://github.com/ahayzen-kdab/cxx-qt/actions it can be seen that when the commit chain including rename to cxx-qt-common to cxx-qt is when it started to occur. So will need to diff between https://github.com/ahayzen-kdab/cxx-qt/commit/7c821a1d4405aa8699af532c72f9bfcae3da28c4 and https://github.com/ahayzen-kdab/cxx-qt/commit/54559b774f3b61d919a31f4b28ab5585ce6b34e1

ahayzen-kdab commented 6 months ago

The diff is quite small, this is when the guard was moved to cxx-qt and added as a bridge that we might not require. So is the whole issue of the missing DLL on Windows something to do with extern "Rust" blocks ? (Note we don't even potentially require this)

ahayzen-kdab commented 6 months ago

So yes turns out that the extern "Rust" in cxx-qt was causing the build failures of a missing DLL on Windows.