Add cxx qt lib extras - Githubissues

Montel commented 5 months ago

It"s WIP. I didn't find where we change it!

Montel commented 5 months ago

ok pb: /target/debug/build/cxx-qt-lib-extras-a62b934a6b1befae/out/39e351642d8689ff-qcommandlineoption.cxx.o" "-c" "/opt/travail/git/cxx-qt/target/debug/build/cxx-qt-lib-extras-a62b934a6b1befae/out/cxx-qt-gen/src/qcommandlineoption.cxx.cpp" cargo:warning=src/core/qcommandlineoption.cpp:9:10: erreur fatale: ../assertion_utils.h : Aucun fichier ou dossier de ce nom cargo:warning= 9 | #include "../assertion_utils.h" cargo:warning= | ^~~~~~~~~~~~~~~~~~~~~~ cargo:warning=compilation terminée. exit status: 1 cargo:warning=ToolExecError: Command "c++" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-gdwarf-4" "-fno-omit-frame-pointer" "-m64" "-I" "/usr/include/qt6/QtCore" "-I" "/usr/include/qt6" "-I" "/opt/travail/git/cxx-qt/target/debug/build/cxx-qt-lib-extras-a62b934a6b1befae/out" "-I" "/opt/travail/git/cxx-qt/target/debug/build/cxx-qt-lib-extras-a62b934a6b1befae/out/cxx-qt-gen" "-Wall" "-Wextra" "-std=c++17" "-o" "/opt/travail/git/cxx-qt/target/debug/build/cxx-qt-lib-extras-a62b934a6b1befae/out/b3615968b6006c75-qcommandlineoption.o" "-c" "src/core/qcommandlineoption.cpp" with args "c++" did not execute successfully (status code exit status: 1).cargo:warning=/opt/travail/git/cxx-qt/target/debug/build/cxx-qt-lib-extras-a62b934a6b1befae/out/cxx-qt-gen/src/qcommandlineoption.cxx.cpp:2:10: erreur fatale: cxx-qt-lib/qstring.h : Aucun fichier ou dossier de ce nom cargo:warning= 2 | #include "cxx-qt-lib/qstring.h" cargo:warning= | ^~~~~~~~~~~~~~~~~~~~~~ cargo:warning=compilation terminée.

=> we need assertion_utils.h + qstring.h so what's missing for cxx-qt-lib in extra ?

Montel commented 5 months ago

ok removing cxx-qt-lib directly now

Montel commented 5 months ago

I hope that it uses qstring.h from cxx-qt-lib and not qt directly :)

Montel commented 4 months ago

What is missing for merging it ? :)

ahayzen-kdab commented 4 months ago

What is missing for merging it ? :)

I think there was only ...

should this go into this repo or it's own ? I think we decided it was fine here for now then later make it depend on stable releases once enough helpers exist.
are there any tests being run with it ? once this is in another repo the the QtWidgets #622 example could be used for this, for now maybe we go without and in #622 i could add those QtWidgets types to -extras?

So maybe we are ready?

Montel commented 4 months ago

Yep we decided to wait after 0.7 for splitting in another repo. We decided to add tests when we will split it as it's more easy.

ahayzen-kdab commented 4 months ago

Meanwhile what is happening to CI, seen Windows and macOS fail once with this in the Upload GitAction actions artifacts of vcpkg logs :thinking:

 Error: Failed to FinalizeArtifact: Unexpected token '<', "<!DOCTYPE "... is not valid JSON

ahayzen-kdab commented 4 months ago

Meanwhile what is happening to CI, seen Windows and macOS fail once with this in the Upload GitAction actions artifacts of vcpkg logs 🤔
 Error: Failed to FinalizeArtifact: Unexpected token '<', "<!DOCTYPE "... is not valid JSON

I'm getting random 500 errors navigating the github website, so suspect it is related. And there is a github incident https://www.githubstatus.com/incidents/5ly0psff2s5d

KDAB / cxx-qt

Add cxx qt lib extras #860