search

KDAB / cxx-qt

Safe interop between Rust and Qt
https://kdab.github.io/cxx-qt/book/
973 stars 67 forks source link

Should types in `extern "C++Qt"` need the `#[qobject]` macro #878

Closed ahayzen-kdab closed 2 months ago

ahayzen-kdab commented 4 months ago

When specifying existing types from C++ in an extern "C++Qt" block should we require that you specify #[qobject] as an attribute to be able to use things like #[qsignal] ?

This would make it consistent with the extern "RustQt" block and allow for us in the future to support any non-QObject types that need extra syntax than just CXX.

LeonMatthesKDAB commented 4 months ago

I would say let's enforce #[qobject] for now.

For stabilization that's better as we can always relax the requirement after 1.0, but we can't add a requirement after 1.0.

ahayzen-kdab commented 2 months ago

Yes, and this was done in #902