search

KDAB / hotspot

The Linux perf GUI for performance analysis.
4.18k stars 257 forks source link

please add optional plugin `kgraphviewerpart` to the AppImage #416

Open GitMensch opened 2 years ago

GitMensch commented 2 years ago

It is totally reasonable to have the minimal AppImage dependencies on the system, in this case: apt install libfuse2 fuse - or manual extraction of the image.

But after doing that and executing either the AppImage and starting hotspot I'm shown:

kf.coreaddons: "Could not find plugin konsolepart"
kf.coreaddons: "Could not find plugin kgraphviewerpart"

It is definitely good to have those dependencies be optional (hotspot starts and works in general) but I'll obviously won't have the full feature set without additional system libraries (and I don't knwo yet how to even get those).

Can you please include these (and possibly more optional) plugins to the AppImage generation?

milianw commented 2 years ago

yes this is planned to some degree.

konsolepart would dramatically increase the size of the AppImage - I'm unsure if that's worth it.

kgraphviewerpart triggers a crash in libkgraphviewer, which I first have to fix upstream.

milianw commented 2 years ago

And FTR: all other optional dependencies should already be included, including QCustomPlot and the rust and D demangling support

GitMensch commented 2 years ago

Sounds good. As I could not found an issue for that: what is konsolepart used for and how would one install it manually?

milianw commented 2 years ago

it's used in the record page of hotspot to show CLI output of client applications in a proper way, i.e. including ansi escape sequence highlighting and so forth.

GitMensch commented 2 years ago

OK, then other than libkgraphviewer that's completely "optional" and only changes the "beauty" of the output, not lead to a "missing feature" in general. Thanks for that information.

GitMensch commented 2 years ago

kgraphviewerpart triggers a crash in libkgraphviewer, which I first have to fix upstream.

Is there an upstream issue to check its status, which you can link to?

GitMensch commented 2 years ago

kgraphviewerpart triggers a crash in libkgraphviewer, which I first have to fix upstream.

Is there an upstream issue to check its status, which you can link to?

ping @milianw - this would allow me to properly check upstream

side note as mentioned in #318:

Can you please add docs for this feature? It seems neither the screenshot nor markdown files were adjusted for this after the PR (and both aren't included in the PR either).

GitMensch commented 1 year ago

another friendly ping on the upstream issue to monitor ...and the question: Does the appimage already use KDDockWidgets 1.7.0? How could I find that out myself?

lievenhey commented 1 year ago

still based on KDDW 1.6. you can see the version in scripts/appimage/Dockerfile

GitMensch commented 11 months ago

kgraphviewerpart triggers a crash in libkgraphviewer, which I first have to fix upstream.

Is there an upstream issue to check its status, which you can link to?

ping @milianw - this would allow me to properly check upstream

side note as mentioned in #318:

Can you please add docs for this feature? It seems neither the screenshot nor markdown files were adjusted for this after the PR (and both aren't included in the PR either).

:-) Friendly ping @milianw after a bit more than a year about the upstream issue and the documentation for this feature.

milianw commented 11 months ago

I don't think there's an upstream issue, and upstream is pretty "dead", meaning we'd have to fix it ourselves. I'm tempted to leave this disabled for now as it's just not working properly and the visualization isn't one I'm missing myself. help welcome!

GitMensch commented 11 months ago

If it would really need a fix ourselves - can you please fork upstream in KDAB and create an issue there with the details (how to reproduce whatever issue happens, the known details of the problem, ...)?

This would then allow me to at least inspect it further, possibly fix it and send a PR with a fix.