search

KDAB / hotspot

The Linux perf GUI for performance analysis.
4.16k stars 257 forks source link

update to appimage docker image to use devtoolset-12 #525

Closed GitMensch closed 1 year ago

GitMensch commented 1 year ago

In the past I've sometimes got some elfutils related problems when using the AppImage; they possibly are fixed with the newer elfutils (0.187, currently used devtoolset-11 has 0.185) and also the other parts (like GCC for building from source) are likely not bad either.

Note: as I actually don't "do docker" and am a merely user of the appImage I cannot test this other than trying the resulting CI build.

GitMensch commented 1 year ago

While the appImage still builds - it seems to not use the updated docker file (build still uses devtools-11).

milianw commented 1 year ago

the docker images are not rebuild automatically, I have to do that manually.

If you know how to do that automatically in a way that we can still test things locally then I'm all ears.

For now, I'll test these changes manually sometime this week and apply them then

Thanks!

GitMensch commented 1 year ago

If you know how to do that automatically in a way that we can still test things locally then I'm all ears.

me and docker: 🤷

For now, I'll test these changes manually sometime this week and apply them then

🚀 Sounds good!

Thanks!

You're welcome, thanks for your work in Hotspot (I obviously like it)!

milianw commented 1 year ago

it doesn't look like centos7 has devtoolset-12:

No package devtoolset-12 available.
No package devtoolset-12-elfutils-devel available.
No package devtoolset-12-elfutils-debuginfod available.

I intend to leverage KDE craft going forward, and then we'd have more up2date libraries as needed. for now I'll close this request (but I include the second patch that updated linuxdeploy, thanks!)

GitMensch commented 1 year ago

I see. Just for my understanding: The idea is to use CentOS7 to ensure that the AppImage uses a glibc version that is widely available, right?

Using KDE Craft would mean not (primarily) using apt (and potentially a bunch of ppa's) but that packaging system to update the AppImage docker to have recent tools and libraries available, correct?

milianw commented 1 year ago

Yes re Centos - it gives maximum compatibility basically when running the AppImage.

Craft compiles basically the world from scratch, and there's a binary cache that's filled from the KDE CI. We lose some compat but gain on the maintainability front and ease-of-use.