KDAB / hotspot

The Linux perf GUI for performance analysis.
4.16k stars 257 forks source link

Disassembly view: add "go to line/address" command #541

Closed GitMensch closed 10 months ago

GitMensch commented 1 year ago

Is your feature request related to a problem? Please describe. I've recognized that I often "scroll around" to switch between several parts of a function. So far it is necessary to remind the place in the horizontal scroll bar, then get back using this (or use the new search feature).

Describe the solution you'd like The easiest option to "skip around" would be a general-use function "go to", ideally with the default shortcut CTRL+G (in the "active" window, like it is done for CTRL+F).

Additional context As there may not be the exact line, and especially not the exact address: position to the first line after the specified one, if there isn't one then position to the last.

Additional to the general usability it would also provide a workaround for #515.

lievenhey commented 11 months ago

You can click on a line to go to the corresponding one in the other view (only those with a colored background work).

lievenhey commented 11 months ago

Waht do you mean by "go to function"? Enter an address and jump there? Or something like: put a marker here and then some shortcuts to jump between markers?

GitMensch commented 11 months ago

On the right:

both seem easy - but I have no clue how to do that.

Nonetheless, your idea of "adding favorite points to fast switch between" is also good, you may want to create a separate issue for that.

But #528 seems to be much more useful than the favorites and may be implemented first.

GitMensch commented 11 months ago

@lievenhey is there any chance for you to tackle this and/or #515 next?

lievenhey commented 11 months ago

sure