KDAB / hotspot

The Linux perf GUI for performance analysis.
4.12k stars 255 forks source link

CallerCallee add jump to source location in disassembly #573

Closed lievenhey closed 9 months ago

lievenhey commented 10 months ago

this patch adds a context menu that allows the user to select if he wants to open the source code or opens the disassembly and focus the selected location

closes: #515

lievenhey commented 10 months ago

@GitMensch I added some prototype jumping the the disassembler. You can ether press F6 (all good shortcuts were already in use) to open a goto menu or use the context menu to jump to a specific line (source code only currently). I know it is a bit clunky but I am trying to figure out what is the best way to add some navigation.

I would like to hear which method work best. (Yes the context menu is hard to use currently / broken, I will fix that later as well as adding it to the assembly side)

GitMensch commented 10 months ago

Thank you for working on this.

I did check the location pane in caller/callee tab and do see both context menu entries - but

Checking F6 yields in the "go to line" being shown, placing "115" in there and pressing Enter does not seem to work either.

Note: all of CTRL+F (in both panes) and F6 (only on the source) has a remarkable time (1-2 seconds) to be shown ?!?

In any case: CTRL+G is already taken, what about ALT+G or CTRL+SHIFT+G?

lievenhey commented 9 months ago

I added it also for the disassembly, but it doesn't work there (currently)