search

KDAB / hotspot

The Linux perf GUI for performance analysis.
4.06k stars 250 forks source link

fix multiline highlighting was ~add ci test for non optional build~ #594

Closed lievenhey closed 5 months ago

lievenhey commented 8 months ago

This commit adds a ci build to build hotspot without optional dependencies. This should prevents bugs like #575 (fails to build without qcustomplot).

lievenhey commented 8 months ago

I encountered a similar problem when I tried debugging my changes. In that case it was impossible to build hotspot without KSyntaxHighlighter. The ci update should catch that in the future.

lievenhey commented 8 months ago

Nice, the ci found the first bug already

lievenhey commented 8 months ago

Multi line comments are now highlighted correctly grafik

lievenhey commented 8 months ago

dammit, it broke the disassembler

lievenhey commented 8 months ago

now it is working correctly

GitMensch commented 8 months ago

Nice work!

the PR's title may should be adjusted, or the changes split into two PRs (I don't think that's necessary as long as it is split in the commits)

lievenhey commented 7 months ago

I split the ci change off into its own pr

GitMensch commented 7 months ago

I do wonder if not resetting the highlighter has any performance impact

lievenhey commented 7 months ago

It has. Until this patch the Highlighter was called on demand. Now it is called once for the whole file.

GitMensch commented 7 months ago

I guess that's good to go after solving the merge conflict.

GitMensch commented 7 months ago

Just wondering: Is there anything blocking the pull here?

lievenhey commented 7 months ago

Milians high workload.