search

KDAB / hotspot

The Linux perf GUI for performance analysis.
4.09k stars 252 forks source link

Automate release #627

Closed lievenhey closed 5 months ago

lievenhey commented 5 months ago

This PR adds an automatic latest release aswell as release-please which provides a pr that can be merged to create a new release.

closes: #605

lievenhey commented 5 months ago

I am not sure if the build-appimage pipeline should be deactivated on the master branch, since the create-latest-release pipeline will take care of that.

GitMensch commented 5 months ago

I currently fail to understand that - the idea is that for each commit on master there is a "continuous" release, no? Then I don't see where that release is, which then would solve the now closed #605.

lievenhey commented 5 months ago

https://github.com/KDAB/hotspot/releases/tag/continuous here but it seems I need to figure something out since it was marked as draft. Will deal with this on Monday. Good find, thanks.

GitMensch commented 5 months ago

Ah, now I see that as it should be: a pre-release release. If that is automatically updated, then this would be fine. Can you adjust it so that it gets an additional asset with a fixed name like hoptspot-continuous.AppImage? Note: interesting to see that the release-push via GH action allows an .AppImage, while @milianw couldn't upload that extension (I assume via GH online adjustment of the release) any more and needed to gzip that up-front. Maybe it won't work over the GH API in the future, or it would be useful to do it similar for "real releases".

lievenhey commented 5 months ago

Done, seems like ether ncipollo/release-action or github automatically add a draft tag. Now I use the github cli to remove that tag.

I don't think changing the name to hotspot-continuous.AppImage is a good idea. The current name is a perfect description of the commit that was used to build the appimage. If we get a bug report we can then use the name to identify which exact version was used. Maybe the bug is already fixed but the user didn't update, etc ...

GitMensch commented 5 months ago

./hotspot... --version has the output, as well as the version info in the GUI. The idea here is to get a stable download URL, and for that we need - additional to the updated release - an identical name.

If you still want the versioned name: what do you think about having the appimage twice (once with a stable name)?