KDAB / hotspot

The Linux perf GUI for performance analysis.
4.05k stars 250 forks source link

Crash(Assertion failure) when opening large data #629

Closed kxxt closed 3 months ago

kxxt commented 4 months ago

Describe the bug hotspot crashed when opening a very large data file(1.72GB).

To Reproduce Steps to reproduce the behavior:

hotspot hotspot_crash.data &> ~/hotspot.log

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Version Info (please complete the following information):

Additional context

unhandled event type 13   unknown type
/usr/include/c++/13.2.1/valarray:588: const _Tp& std::valarray<_Tp>::operator[](std::size_t) const [with _Tp = long long int; std::size_t = long unsigned int]: Assertion '__i < this->size()' failed.
zsh: IOT instruction (core dumped)  hotspot hotspot_crash.data

hotspot.log

Thanks for creating such a nice tool for analyzing performance. I really love using it. Large files are usually difficult to handle in GUI applications, which I think is what this bug reveals.

hotspot_crash.data is saved by cargo-flamegraph command.

It is attached here in a zstd compressed form. Due to github's limitation, it is again compressed with gzip before uploading: hotspot_crash.data.zst.gz

lievenhey commented 3 months ago

Hi, thanks for finding this bug. I hope I have found the issue. I was able to open your dump with the following appimage.

Can you try again with that version to see if it fixed the bug?

kxxt commented 3 months ago

Hi, thanks for finding this bug. I hope I have found the issue. I was able to open your dump with the following appimage.

Can you try again with that version to see if it fixed the bug?

Hi, thanks for your fix. I can confirm that the bug is fixed by your PR.