search

KDAB / hotspot

The Linux perf GUI for performance analysis.
4.05k stars 250 forks source link

ignore empty command line arguments #659

Open GitMensch opened 3 months ago

GitMensch commented 3 months ago

Those can be passed by tools calling HotSpot and lead to "File '' does not exist." error messages.

One example "tool" is vscode - you can either start external programs with no arguments or with user-inputs (for example a , but if you have an empty user input (aka "just start hotspot") you get that error message.

GitMensch commented 3 months ago

Hm, thinking about that; maybe it would be nice to allow opening hotspot without "perf.data", even if it exists - this could also be triggered by the empty file "" (or a new binary option).

Thoughts?

milianw commented 2 months ago

Hm, thinking about that; maybe it would be nice to allow opening hotspot without "perf.data", even if it exists - this could also be triggered by the empty file "" (or a new binary option).

Thoughts?

Up to you, if you see a need for it I'm not going to oppose a patch for that.

GitMensch commented 2 months ago

Hm, thinking about that; maybe it would be nice to allow opening hotspot without "perf.data", even if it exists - this could also be triggered by the empty file "" (or a new binary option). Thoughts?

Up to you, if you see a need for it I'm not going to oppose a patch for that.

I think if we extend #660 to start on several pages (for starters at least "recording" and "open") this issue is solved. Please have a look there any comment about a possible --startPage or how you'd name an option.