search

KDAB / knut

Knut is an automation tool for code transformation using scripts.
Other
5 stars 8 forks source link

fix: message map extraction when namespaces are used #14

Closed narnaud closed 2 weeks ago

narnaud commented 2 weeks ago

The message map may be in a namespace, we can't assume it is top-level.

Montel commented 2 weeks ago

Is it possible to add a autotest ?

narnaud commented 2 weeks ago

Is it possible to add a autotest ?

You are correct, I should add autotest for fixes, will do.

LeonMatthesKDAB commented 2 weeks ago

@narnaud Have you checked how this affects performance? I think I remember trying something similar and it caused the whole query to be significantly slower, because it's now giving a lot more possible results that need to be filtered by the predicates? But maybe that was on a different query.

narnaud commented 2 weeks ago

@narnaud Have you checked how this affects performance? I think I remember trying something similar and it caused the whole query to be significantly slower, because it's now giving a lot more possible results that need to be filtered by the predicates? But maybe that was on a different query.

I think the problem was when we were using it for contextual scripting... performances are less an issue when used in script. But no, I didn't test it for performances.

Maybe I could add an optional test for the namespace, not sure how to do that (will check later).

narnaud commented 2 weeks ago

All fixed: