Use pregenerated images based on screen dpi

KDAB / kuesa

Professional 3D asset creation and integration workflow for Qt

https://www.kuesa.com/

139 stars 27 forks source link

Use pregenerated images based on screen dpi #101

Closed lemirep closed 5 years ago

lemirep commented 5 years ago

Add python tool to pregenerate assets for various dpis
Make StyledSlider/StyledSwitch use pregenerated assets

Task-Id: KUE-598

lemirep commented 5 years ago

Simplifies the code a bit, looks alright (not pixel perfect) on most platforms. Should fix the huge number of vertices in QtQuick

mkrus commented 5 years ago

Like the other patch, this UI is much too big on iPads

Are both patches needed?

lemirep commented 5 years ago

I'd suggest we get this is even though it's not perfect on all platforms, gets us closers to not having 10000 vertices drawn by QtQuick. I suspect iPad doesn't report the correct dpi and chooses the wrong assets. Can't really fix test for this on my side but I'd assume someone with an ipad could fix that with minimal amount of code changes. Other patch from Nuno is not required.

mkrus commented 5 years ago

does it work on Android tablets with hidpi?

lemirep commented 5 years ago

Size is adequate on my phone

mkrus commented 5 years ago

While I agree it's good in fixing the rendering performance it also breaks scaling, I think because the dpi selection fails to take into account the Screen.devicePixelRatio. So on macOS (retina), and iPad, everything is way too large

lemirep commented 5 years ago

Ok given we've been stuck on this for almost 2 months, I'll let you take over an fix whatever needs to be for it to work properly on iPad as I can't test it here.

lemirep commented 5 years ago

Replaced by Mike's patch