KDAB / kuesa

Professional 3D asset creation and integration workflow for Qt
https://www.kuesa.com/
139 stars 27 forks source link

car-scene: disable Draco on Android and iOS #109

Closed lemirep closed 5 years ago

jjcasmar commented 5 years ago

Should we document that we dont support draco on android/ios? Maybe an option to force it anyway?

Otherwise, looks okay

lemirep commented 5 years ago

Well we do support it on Android. It's just that if you try the car-scene on your phone, the app freezes for 30s while decompressing the assets. So I guess we could document that draco can be slow on lower end devices but not sure we should explicitly say we don't support it on these platforms.

jjcasmar commented 5 years ago

Right, bad wording on my side. How about saying that by default is disabled but you can force it with some option?

mkrus commented 5 years ago

the obvious way for that (assuming it's even possible) is for the config test to default to no on ios/android and the user could force it to on if needed. Although I guest that becomes an all or nothing change rather than just for the demo

lemirep commented 5 years ago

I've disabled the autodetection of the draco feature on Android and WinRT as a separate pull request (https://github.com/KDAB/kuesa/pull/116). However I haven' t found a way to make it work for iOS as Qt only knows whether it is configured for Darwin but doesn't allow to filter whether it's iOs or not

mkrus commented 5 years ago

think this one can be abandoned in favour of the global fix (which can include iOS)