KDAB / kuesa

Professional 3D asset creation and integration workflow for Qt
https://www.kuesa.com/
139 stars 27 forks source link

Fix unit tests: #55

Closed lemirep closed 5 years ago

lemirep commented 5 years ago
jjcasmar commented 5 years ago

I would say commit message and changes are unrelated. The change in the is valid function has nothing to do with the tests. Same happens for the TEXCOOR_1/2.

Regarding the refactor of the is valid function, I wouldn't say its easier to understand now. You are defining a lambda, which is invoked directly. Also, you are capturing the attributes and returning from the lambda. I found the current implementation (based on std::find_if) easy, but if you prefer to modify it, I would suggest going for a raw loop instead of a lambda