Performance issues in src/algorithms/donut.py(P2)

KDD-OpenSource / DeepADoTS

Repository of the paper "A Systematic Evaluation of Deep Anomaly Detection Methods for Time Series".

MIT License

569 stars 117 forks source link

Performance issues in src/algorithms/donut.py(P2) #209

Open DLPerf opened 3 years ago

DLPerf commented 3 years ago

Hello,I found a performance issue in the definition of fit , src/algorithms/donut.py, tf_session = tf.Session was repeatedly called in for col_idx in trange(len(X.columns)): and was not closed. I think it will increase the efficiency and avoid out of memory if you close this session after using it.

Here are two files to support this issue,support1 and support2

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

Chaoste commented 3 years ago

Hey, that sounds reasonable. It would be great if you file a PR. I will review it :)