search

KEINOS / Phar_Box3_installer

✅ A downloader to help install/setup the latest BOX3 (box.phar).
https://qiita.com/KEINOS/items/62653805b554a538d970
MIT License
0 stars 1 forks source link

Fail checking: "phar.readonly" #7

Open KEINOS opened 6 years ago

KEINOS commented 6 years ago

Box3 installer doesn't check PHP.ini's "phar.readonly" setting properly.

Tested env:

$ curl -LSs https://keinos.github.io/Phar_Box3_installer/installer.php | php
Box Installer
=============

Environment Check
-----------------

"-" indicates success.
"*" indicates error.

 - You have a supported version of PHP (>= 5.3.3).
 - You have the "phar" extension installed.
 - You have a supported version of the "phar" extension.
 - You have the "openssl" extension installed.
 * Notice: The "phar.readonly" setting needs to be off to create Phars.
 - The "detect_unicode" setting is off.
 - The "allow_url_fopen" setting is on.

Everything seems good!

Download
--------

 - Downloading releases...
 - Reading releases...
    Release: 3.0.0-beta.0
    Release: 3.0.0-alpha.7
    Release: 3.0.0-alpha.6
    Release: 3.0.0-alpha.5
    Release: 3.0.0-alpha.4
    Release: 3.0.0-alpha.3
    Release: 3.0.0-alpha.2
    Release: 3.0.0-alpha.1
    Release: 3.0.0-alpha.0

    Latest release -> 3.0.0-beta.0
 - Application download was found
 - Downloading Box v3.0.0-beta.0 ...
 - Checking if valid Phar ... OK.
 - Making Box executable ...

Box installed!

related issue

KEINOS commented 6 years ago

Wouldn't it better to ask "before" downloading, when PHP.ini setting doesn't fulfill the requirements? Or guide where and how to change the settings?