search

KEINOS / TPL-PHP-HelloWorld

✅ Overly-super-cautious "Hello World" in PHP7 and PHP8 for fun.
Apache License 2.0
2 stars 0 forks source link

The tests doesn't run if the package name (the repo dir name) is in kebab-case #44

Closed KEINOS closed 4 years ago

KEINOS commented 4 years ago

Hyphens are not allowed to use in namespaces.

KEINOS commented 4 years ago

Didn't fix it. Re-open the issue.

Only adding a replacement string, such as "TPL-PHP-HelloWorld", to replace as kebab-case won't work.

It breaks the functionality of the initialization script which replaces the files that reference the dir as well and the absolute paths can't determine the original, the proper, dir name.

KEINOS commented 4 years ago

The most basic reason is that the initialize_package.php re-writes the string itself.

We should emit the initialize_package.php to be the target to be replaced.