KELLIA / dictionary

The dictionary comprised of the Coptic lexicon created by the BBAW and interface by Coptic SCRIPTORIUM. Currently deployed at https://coptic-dictionary.org
28 stars 12 forks source link

Add phrase graphs for other function words #130

Open amir-zeldes opened 4 years ago

amir-zeldes commented 4 years ago

Currently supported: Nouns, verbs, prepositions Missing: auxiliaries, pronouns

Question: adverbs? (note their 'phrases' are the adverb itself)

phoenix-mossimo commented 4 years ago

Can you reduce the size of the picture so that it occupies 2 rows only? Its too large now

Also, on the mobile devices it is squeezed out of the screen.

phrase_graphs

amir-zeldes commented 4 years ago

Thanks for reporting! I tried playing around with the size and I think any smaller is too painful on the eyes IMO. However I think I have the mobile issue fixed now: if the screen is too small (also in desktop mode), the thumbnail will wrap under the form table. Is this OK to close?

amir-zeldes commented 3 years ago

Comment from @phoenix-mossimo :

Can it be reduced to two rows of the table?

I tried reducing it and it's too small IMO:

image

Especially when there's more than one line it looks better this way, and when there's only one line there's plenty of space anyway:

image

Personally I find the smaller size a bit painful to look at (especially with some older users in mind), but if there are other supporters I'd be willing to reconsider. What do you think @ctschroeder ?

phoenix-mossimo commented 3 years ago

Ah, but there is already an icon "Form phrase network graph" with the same function. Do you really need also a preview? This picture disrupts a clear table layout, especially when there are many forms available, check e.g. ⲁⲅⲅⲉⲗⲟⲥ.

amir-zeldes commented 3 years ago

The preview can indicate if the graph is worth looking at, since it can be very dense or very sparse. It's also a good way to make this new feature easier to discover, and if there are multiple form links then the table gives those, while the thumbnail shows the the graph for the lemma form (see the entry for ⲛⲟⲉⲓ for example, where the form without 'e' has a separate graph)

ctschroeder commented 3 years ago

I'm just catching up on this issue now. I want to poke around a bit -- can we wait a couple of days? Thanks.