KES777
commented
6 years ago For reference:
<kes> pink_mist: Hi. will you apply the https://github.com/KES777/mojo/pull/55?
<pink_mist> kes: I don't see the point of it, Mojo::Base doesn't come with attributes itself, and no other module that I can find after a quick skim that is a direct descentant of Mojo::Base has that message either.
<pink_mist> kes: but even if I thought it was a worthwhile PR I am not in a position to apply it
<pink_mist> *descendant
<kes> pink_mist: there is Mojolicious::Controller which do that
<pink_mist> perhaps change Mojolicious::Controller then ... it seems to be the odd one out
<kes> My opinion that despite on Mojo::Base do not provide attributes we still inherit them. In this case the count of inherited is 0. Perhaps Mojo::Base may provide one of attribute in future. Thus 'inherits all attributes' will be still correct.
<kes> whose I can ping who is in a position to review this?
<kes> *whose can I ping
<pink_mist> in that case you should make the change for -all- the descendants of Mojo::Base, not just Test::Mojo
<kes> before I do that, would it be correct? I want to get feedback first.
<pink_mist> right, I have no idea
<kes> whose can I ping? or you also do not know?
<pink_mist> don't know, it would probably be jberger or batman
<kes> thank you.
<kes> Just checked. The only Mojolicious::Controller says that: it inherits all attributes.
<kes> jberger: would it be better to say same for other modules which inherit from Mojo::Base? despite on Mojo::Base do not provide any attributes now we all the same inherit them (currently zero count). Or we should just fix Mojolicous::Controller POD to not tell about inheritance?
Summary
Mention about inheritance
Motivation
Other modules mention about attributes inheritance: link