search

KFNEXUS / KFNEXUS.github.io

GNU Lesser General Public License v3.0
3 stars 6 forks source link

Fix typo in Kirk talents #50

Closed FND closed 6 years ago

FND commented 6 years ago

At least this seems to be a typo, @CrazyVulcan?

PS: I've also noticed that the ID third_of_five_71525 appears both as a captain and as a crew upgrade; could we fix that?

FND commented 6 years ago

By the way, I find issues like these because, as previously mentioned elsewhere, I maintain a separate (incomplete) application which imports Utopia's data and validates it: https://github.com/FND/stawker/tree/master/src/models https://github.com/FND/stawker/tree/master/src/importer/converters That is, I have fairly strict definitions of what ships, captains, upgrades etc. are supposed to look like and ensure that the data matches those definitions. It might be worth having a conversation about incorporating this validation into Utopia - what do you think?

CrazyVulcan commented 6 years ago

Sure I would love that, just understand I am a rather newcomer to this.

FND commented 6 years ago

Excellent. I'll see about writing up a proposal, making sure that it's easy to understand without deep tech experience. Might take a while though; perhaps even sometime later this year (not because it'd be a huge proposal, but because I'll remain busy with other stuff for a while).