Closed KGrewal1 closed 8 months ago
Attention: 25 lines
in your changes are missing coverage. Please review.
Comparison is base (
956179f
) 92.13% compared to head (b874db1
) 91.33%.
Files | Patch % | Lines |
---|---|---|
src/lbfgs/strong_wolfe.rs | 68.35% | 25 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes the Strong Wolfe line search to use weight decay in evaluating Armijo condition.
This is a correctness fix that is confirmed in testing as the value converged upon when there is weight decay is now the same with and without linesearch adding a test to ensure this.