search

KGrewal1 / candle-optimisers

A collection of optimisers for use with candle
MIT License
30 stars 2 forks source link

Typo #3

Closed nullptr2nullptr closed 1 year ago

nullptr2nullptr commented 1 year ago

Hi @KGrewal1, this looks like a really cool addition to the Candle ecosystem!

I noticed a small typo in the name of your repo - and am not sure if it is intentional? I think that you can change this in the Settings tab.

KGrewal1 commented 1 year ago

If this is s vs z in optimisers, I tend to try to stick to s as it is the British spelling, and as I'm writing up stuff for submission I tend to try to stick to the Britsh one. If it's a different typo, I haven't noticed it. Probably not ideal I've spelt it with a 'z' in the tests though

nullptr2nullptr commented 1 year ago

I meant the is the optimsers "typo". Thanks for the clarification!