Closed KGrewal1 closed 10 months ago
Attention: 47 lines
in your changes are missing coverage. Please review.
Comparison is base (
ebcbd32
) 99.18% compared to head (7f7ca1a
) 94.81%.
Files | Patch % | Lines |
---|---|---|
src/lbfgs.rs | 83.33% | 24 Missing :warning: |
src/lbfgs/strong_wolfe.rs | 86.11% | 20 Missing :warning: |
src/lib.rs | 0.00% | 3 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Adds in an implementation of LBFGS: this is not equivalent to the pytorch implementation as each step is one change (as opposed to torch where it is up to max_iter). This is functional but can still be optimised more.