KI-SSC-TEST / design.gitlab

MIT License
0 stars 0 forks source link

auto-add subfolders #1

Closed A783270 closed 2 years ago

A783270 commented 2 years ago

In GitLab by @psimyn on Oct 23, 2017, 14:20

null

A783270 commented 2 years ago

In GitLab by @tauriedavis on Nov 10, 2017, 04:08

What is the idea behind auto-adding subfolders? I have this issue as one of our design OKRs: https://gitlab.com/gitlab-org/gitlab-design/issues/76

It includes defining the different sections/subsections that will need to be added. I was going to manually add all these but not sure if the frontend team had a different idea based on this issue?

A783270 commented 2 years ago

In GitLab by @tauriedavis on Nov 13, 2017, 23:53

I'm going to start adding folders manually unless there are objections @psimyn @winh :grinning:

A783270 commented 2 years ago

In GitLab by @winh on Nov 14, 2017, 01:53

@tauriedavis It could be that storybook doesn't handle files in subfolders but that's probably the worst that can happen. I'm really busy getting 10.2 ready as fast as possible but if you run into any trouble while adding things manually, I can try to help next week. (or @psimyn if you have time?)

A783270 commented 2 years ago

In GitLab by @tauriedavis on Nov 14, 2017, 03:55

Thanks @winh! Ill see what I can do on my own :ok_hand:

A783270 commented 2 years ago

In GitLab by @psimyn on Nov 14, 2017, 04:10

adding folders is fine - issue was whether or not they would be auto-detected and appear in the sidebar. If not they'll need to be imported in stories/index.js.

Let me know if you have any questions/troubles

A783270 commented 2 years ago

In GitLab by @gtsiolis on Jan 4, 2019, 03:56

@psimyn this is no longer relevant since storybook related code has moved to gitlab-ui, right? /cc @winh @tauriedavis

A783270 commented 2 years ago

In GitLab by @gtsiolis on Jan 4, 2019, 03:56

assigned to @psimyn

A783270 commented 2 years ago

In GitLab by @psimyn on Jan 4, 2019, 06:34

yep, thanks @gtsiolis :raised_hands:

A783270 commented 2 years ago

In GitLab by @psimyn on Jan 4, 2019, 06:34

closed

A783270 commented 2 years ago

In GitLab by @gtsiolis on Jan 4, 2019, 18:53

Thanks @psimyn! :basketball:

A783270 commented 2 years ago

In GitLab by @hfyngvason on Sep 19, 2019, 14:52

mentioned in merge request !1566