search

KI-SSC-TEST / design.gitlab

MIT License
0 stars 0 forks source link

Highlight HEX values in the body of Pajamas pages #29

Open A783270 opened 2 years ago

A783270 commented 2 years ago

In GitLab by @rayana on Apr 2, 2020, 21:53

Follow-up from "Update hex values for accessible palette update"

The following discussion from !1787 should be addressed:

@rayana Another improvement I can suggest for a different MR would be using the bg color of the variable in the paragraph when mentioning the design token -- for example, $gray-950 (#1f1f1f) so we can make a visual reference to the list below. WDYT?

Here's an example that kind of convey my idea: Atom has a package that allows you to preview a HEX/RGB value inline while working on your CSS file. https://atom.io/packages/pigments

It's just this random idea I had. But it would be cool to be able to identify the color mentioned in the copy/body of a page, and highlight it to designers. Something like this:

Screen_Shot_2020-04-02_at_16.51.21

@jeldergl Ah yes, like we do in inline code blocks in the product, e.g. #000000 and #ffffff. I don’t think I’d know where to start for dev on something like that, would you be okay opening an issue for it? I think it’s a great idea.

A783270 commented 2 years ago

In GitLab by @rayana on Apr 2, 2020, 21:53

FYI @jeldergl

A783270 commented 2 years ago

In GitLab by @rayana on Apr 2, 2020, 21:53

mentioned in merge request !1787

A783270 commented 2 years ago

In GitLab by @gitlab-bot on Apr 8, 2020, 05:50

Setting ~"devops::create" ~"group::ecosystem" based on ~"Category:FE/UX Foundations".

A783270 commented 2 years ago

In GitLab by @jeldergl on Jul 3, 2021, 01:35

@rayana I'm wondering how viable you think this still is? The reason I ask is because it's related to hex values, and I think we should be using color variables as much a possible in component documentation where the variables are abstracted from the hex values. I think there would be limited places, like Foundations > Color where this would be applicable, and if it's just a handful of instances I'm okay with not having color displayed inline.

A783270 commented 2 years ago

In GitLab by @jeldergl on Jul 13, 2021, 01:16

If this is still relevant could you add an issue weight to this? Thanks!

Adding a rough weight estimate of 2 if this is to move forward.