search

KI-SSC-TEST / design.gitlab

MIT License
0 stars 0 forks source link

Card docs > Add single stat links #33

Closed A783270 closed 2 years ago

A783270 commented 2 years ago

In GitLab by @tauriedavis on Apr 4, 2020, 24:27

In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/1609, we reference a single state component. This component was not yet added to Pajamas. Not that it is, link to it and add it is a related component.

Example from GitLab UI:

CleanShot_2021-07-06_at_11.34.08

A783270 commented 2 years ago

In GitLab by @tauriedavis on Apr 4, 2020, 24:28

marked this issue as related to gitlab-org/gitlab-design#817

A783270 commented 2 years ago

In GitLab by @tauriedavis on Apr 4, 2020, 24:28

mentioned in merge request !1609

A783270 commented 2 years ago

In GitLab by @gtsiolis on Nov 9, 2020, 22:48

mentioned in merge request !2157

A783270 commented 2 years ago

In GitLab by @jeldergl on Jul 6, 2021, 22:05

changed the description

A783270 commented 2 years ago

In GitLab by @jeldergl on Jul 6, 2021, 22:09

@tauriedavis the design for the single state is in the Data Visualization file, so I think this can be closed. What's in GitLab UI doesn't match the design though, and the design doesn't have hover states like GitLab UI, but I don't remember those states being part of the design since these aren't interactive other than maybe tooltips/popovers.

/cc @npost

A783270 commented 2 years ago

In GitLab by @tauriedavis on Jul 7, 2021, 01:25

I think this issue was to link to single stat from the card docs (such as here https://design.gitlab.com/components/card#single-stat). After we add the links, then we can close this. Seems like this is ready for development

A783270 commented 2 years ago

In GitLab by @tauriedavis on Jul 7, 2021, 01:25

changed the description

A783270 commented 2 years ago

In GitLab by @jeldergl on Jul 7, 2021, 02:21

Do you think adding the links is worth doing? Per our proposed template update we wouldn't be including extensive alternate component explanations and links.

A783270 commented 2 years ago

In GitLab by @tauriedavis on Jul 7, 2021, 03:45

Hard for me to say currently but it does look like we do still have related components linked, so this would at least fall under that (unless we dont think they are really that related)

A783270 commented 2 years ago

In GitLab by @jeldergl on Jul 7, 2021, 04:56

I don't think they're related, but @npost could you share your perspective?

A783270 commented 2 years ago

In GitLab by @npost on Jul 7, 2021, 12:22

What's in GitLab UI doesn't match the design though, and the design doesn't have hover states like GitLab UI, but I don't remember those states being part of the design since these aren't interactive other than maybe tooltips/popovers.

They are interactive when they have popovers.

Screenshot_2021-07-07_at_07.48._2x

This is to fix the hover state when no popover: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1488

ard for me to say currently but it does look like we do still have related components linked, so this would at least fall under that (unless we dont think they are really that related)

I wouldn't say they are related really.

A783270 commented 2 years ago

In GitLab by @tauriedavis on Dec 17, 2021, 24:19

mentioned in merge request !2673

A783270 commented 2 years ago

In GitLab by @tauriedavis on Dec 17, 2021, 24:36

mentioned in merge request !2674

A783270 commented 2 years ago

In GitLab by @jareko on Dec 17, 2021, 21:26

mentioned in commit 727c9e42bddbacc345c4bea0274dfa2a2618fd63