search

KI-SSC-TEST / design.gitlab

MIT License
0 stars 0 forks source link

"Edit in JSFiddle" redirects to a fiddle that does not work #40

Closed A783270 closed 2 years ago

A783270 commented 2 years ago

In GitLab by @nfriend on Apr 14, 2020, 24:16

Problem

Many of our the pages in our Pajamas documentation have live demos that use JSFiddle. For example: https://design.gitlab.com/components/breadcrumb/

When I click the Edit in JSFiddle button in the top right of the embedded example, I get redirected to a fiddle that doesn't work.

Steps to reproduce

  1. Navigate to https://design.gitlab.com/components/breadcrumb/
  2. Scroll down to the Demo section and click Edit in JSFiddle
  3. You will be redirected to jsfiddle.net
  4. In the top-left of the page, click Run

Expected behavior

The same working demo shown in the embedded example on https://design.gitlab.com/components/breadcrumb/ is shown is JSFiddle's Result pane.

Actual behavior

The embedded example in https://design.gitlab.com/components/breadcrumb/ works, but the version on jsfiddle.net only renders a blank, white Result pane.

Also...

Each time the Edit in JSFiddle button is clicked, a small <textarea> is appended to the end of the page:

image

(Good catch, @tauriedavis)

A783270 commented 2 years ago

In GitLab by @nfriend on Apr 14, 2020, 24:16

/cc @tauriedavis :slight_smile:

A783270 commented 2 years ago

In GitLab by @gtsiolis on Apr 14, 2020, 24:43

@nfriend the JSFiddle issue was also reported some months ago in https://gitlab.com/gitlab-org/gitlab-ui/issues/162#note_162930165.

I think this a broader issue affecting all components. I can't open any component properly in JSFiddle.

A783270 commented 2 years ago

In GitLab by @tauriedavis on Apr 14, 2020, 24:45

How useful is the JSFiddle link? Is it reasonable to remove it or worth fixing?

A783270 commented 2 years ago

In GitLab by @nfriend on Apr 14, 2020, 23:14

@tauriedavis It's probably not super useful in the context of Pajamas, but looking at this a bit closer, I believe this is the same view that is rendered in Storybook: https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-breadcrumb--default, where it's much more useful.

I'm now realizing this is probably better as a gitlab-ui issue, so I'll mark this one a duplicate of https://gitlab.com/gitlab-org/gitlab-ui/issues/162 (thanks @gtsiolis).

A783270 commented 2 years ago

In GitLab by @nfriend on Apr 14, 2020, 23:14

marked this issue as a duplicate of gitlab-org/gitlab-ui#162

A783270 commented 2 years ago

In GitLab by @nfriend on Apr 14, 2020, 23:14

closed

A783270 commented 2 years ago

In GitLab by @nfriend on Apr 14, 2020, 23:14

marked this issue as related to gitlab-org/gitlab-ui#162