search

KIRBXx / TRMedia

TRM - Main
1 stars 0 forks source link

Internet Explorer + Mobile Layouts #17

Closed KIRBXx closed 10 years ago

KIRBXx commented 10 years ago

The Website looks terrible when viewed from Internet Explorer and Mobile Devices. We need to change a few things, theme wise, to make things look a bit better. I have disabled the use of Internet Explorer on the site, for now.

rickr commented 10 years ago

Original author didn't have the correct IE HTML hacks. Added them to the home view and template view. In commits 65538c34269dbafbe667750b3678e096edd4267f and 469c1ff19652d34ba62e1943d3dfcefc5aa79868

Mobile still needs to be looked at.

rickr commented 10 years ago

Tested in IE 10 and the images looked OK (I don't have them on the dev box so I didn't catch them not loading).

I personally wouldn't disable all IE access because of it. You could try to detect just IE8, or just show a banner at the top of the page.

Unfortunately it looks like IE8 has the biggest market share out of the IEs....go figure: http://www.netmarketshare.com/browser-market-share.aspx?qprid=2&qpcustomd=0

Rick

:wq!

On Sat, Jan 4, 2014 at 11:46 PM, James notifications@github.com wrote:

It is now quite a bit better on IE, but still not to where I want to remove the redirect to the "old browser" page.

Pages like the gallery still need a ton of work.

— Reply to this email directly or view it on GitHubhttps://github.com/KIRBXx/TRMedia/issues/17#issuecomment-31596366 .

KIRBXx commented 10 years ago

I say we just show a banner/popup of some sort. Not sure how to detect just IE8, though...

rickr commented 10 years ago

Warning banner added in 97efbdde8ef13f7bafc21023f7824cae7f8ae54d

KIRBXx commented 10 years ago

IE is good to go. Still a couple Mobile bugs to work out, but they should be easy to kill!

KIRBXx commented 10 years ago

1 Mobile bug has been fixed. 1 bug remains.

Here is a screenshot of the "bug" - http://imageshack.com/a/img856/1372/mzw0.png

The featured image(s) do not span across the page, leaving the white space below the image.

KIRBXx commented 10 years ago

Another mobile bug caused with new Navigation update. When you click on the nav toggle button on mobile, it lists the navigation buttons below, but for some reason, the background color for these buttons are transparent.

Changing the color to the original state changes other things within the site. We must create new classes for the change to work...