search

KIT-CMS / Excalibur

Analysis repository for Z+Jet studies
1 stars 4 forks source link

No default behaviour for th ZJetGenWeightProducer #56

Closed HerrHorizontal closed 4 years ago

HerrHorizontal commented 4 years ago

In case of a configuration of Excalibur, where GenWeights are requested (https://github.com/KIT-CMS/Excalibur/blob/GENWeights/Compile/src/Producers/ZJetGenWeightProducer.cc#L49-L54), but the according skims do not provide the necesary information (due to older skims, wrong configuration), Excalibur should write default weights 1.0 into the requested weights.

HerrHorizontal commented 4 years ago

You can find the corresponding skimming code in https://github.com/KIT-CMS/Kappa/blob/GenWeights/DataFormats/interface/KInfo.h#L174-L179

dsavoiu commented 4 years ago

I guess for this to work, you would need to check if the index exists in getLheWeight and return 1.0 if it doesn't (or throw an exception if failOnError is set).