search

KIT-CMS / Excalibur

Analysis repository for Z+Jet studies
1 stars 4 forks source link

[LeptonSFProducer] Rewrite the LeptonSFProducer. Less duplicates and easier to understand code. #89

Closed cverstege closed 2 years ago

cverstege commented 2 years ago

Refactoring of the LeptonSFProducers, condensing common code.

RHofsaess commented 2 years ago

Very nice, thanks! I only left some minor inline comments.

cverstege commented 2 years ago

Some changes were made. I reverted back to using optionalWeights, as this makes things easier when comapring Reco lovevl with efficiencies to Gen level. The main weight for gen level should not be changed by the efficiencies at reco level. Additionally I implemented "correct" uncertainty handling according to the MuonPOG: https://cms-talk.web.cern.ch/t/questions-on-the-combination-of-muon-tnp-uncertainties/5968 Please re-review @HerrHorizontal and @RHofsaess

cverstege commented 2 years ago

I'll squash and merge once approved, so it's only one commit on the master branch in the end.